Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
This is essentially a duplicate of #2294. |
Contributor
true. Edwin, see if you can merge them and see what's left. also, have you installed pre-commit? |
Merged
8 tasks
Contributor
Author
|
Oh oops I completely missed that! (my browser had an outdated view of the PR tab). I'll merge those changes in here once that's done Yeah I've installed pre-commit I'm running all my changes through that before pushing |
Contributor
|
well, #2294 is done, please pull master and see if there's anything left? |
akinomyoga
reviewed
Mar 24, 2025
hyperupcall
changed the title
completion directory
akinomyoga
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit b6f62a4 introduced some ShellCheck errors. This cleans up most of the low-hanging fruit (shell quoting, extraneous dollar sign in arithmetic context, inability to follow non-constant source, etc.). Note that there are still errors remaining, but much fewer exist after this change. Maybe I can fix the rest of the errors in another PR?
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.